gtkroomlist responsiveness

Sadrul Habib Chowdhury imadil at gmail.com
Sun Jan 6 11:10:47 EST 2008


* Gabriel Schulhof had this to say on [06 Jan 2008, 15:46:59 +0200]:
> Hi!
> 
> The use of while(g_main_context_iteration(NULL, FALSE)); as in the patch
> below makes gtkroomlist much more responsive (read: usable) on slow
[snip]
> +
> +       while(g_main_context_iteration(NULL, FALSE));

Perhaps you can explain why this patch makes it more responsive? There
might be other cleaner fixes to the problem.

[snip]
> 
> Since pidgin_roomlist_add_room() is a UI op called fairly one-to-one
> from the core (i.e., the core passes it straight through from the prpl),
> one idea might be to place the second "while(g_main_..." line into the
> core after the call to the UI op, rather than at the end of the UI op.

Nope. This can't be done in the core since it assumes the use of the
GLib mainloop, which isn't a requirement for libpurple (this is the same
reason functions like g_idle_add etc. can't be used in the core).

Sadrul




More information about the Devel mailing list