msimprpl status update

Jeff Connelly shellreef at gmail.com
Sun Jan 27 16:53:04 EST 2008


On Jan 27, 2008 2:14 AM, Mark Doliner <mark at kingant.net> wrote:
> On Sat, 26 Jan 2008 21:15:19 -0800, Jeff Connelly wrote
> Hey Jeff, thanks for the status update (and the bug fixes!).  [...]
> I'm not sure I merged this change correctly, so please double check the code
> in trunk when you have a chance:
> -     } else if (strstr(msg_text, "!!!ZAP_SEND!!!=RTE_BTN_ZAPS_")) {
> +     } else if (strstr(msg_text, "!!!ZAP_SEND!!!=RTE_BTN_ZAPS_") == msg_text) {
The first line is correct; I just pushed a fix for this in
03e06749761ecfb8047770b6510ea4ba297fcaf6.

> Anyway, the real reason for this email is to let you know about
> PurpleCircBuffer.  [...]
This option looks attractive but it appears to only be used for
outgoing transmission buffers within the other protocol plugins:

mbp:protocols jeff$ grep -r PurpleCircBuffer *
bonjour/jabber.h:	PurpleCircBuffer *tx_buf;
irc/irc.h:	PurpleCircBuffer *outbuf;
jabber/jabber.h:	PurpleCircBuffer *write_buffer;
jabber/jabber.h.orig:	PurpleCircBuffer *write_buffer;
msn/httpconn.h:	PurpleCircBuffer *tx_buf;
msn/servconn.h:	PurpleCircBuffer *tx_buf;
msnp9/httpconn.h:	PurpleCircBuffer *tx_buf;
msnp9/servconn.h:	PurpleCircBuffer *tx_buf;
oscar/oscar.h:	PurpleCircBuffer *buffer_outgoing;
oscar/peer.h:	PurpleCircBuffer *buffer_outgoing;
sametime/sametime.c:  PurpleCircBuffer *sock_buf;
sametime/sametime.c:  PurpleCircBuffer *circ = pd->sock_buf;
simple/simple.h:	PurpleCircBuffer *txbuf;
yahoo/yahoo.h:	PurpleCircBuffer *txbuf;
yahoo/ycht.h:	PurpleCircBuffer *txbuf;

Still it could be useful within msimprpl. I filed
http://developer.pidgin.im/ticket/4735 to keep track of this
possibility.

-Jeff




More information about the Devel mailing list