im.pidgin.pidgin: 04e7d54475c3ddf91ad523e3e58521bc4fa59c85

[Eoin Coffey]

2008/1/31 Will Thompson <will at willthompson.co.uk>:

> On Thu, Jan 31, 2008 at 09:23:51AM -0700, Eoin Coffey wrote:
> > The only place where I could find wants_to_die being used in libpurple
> > (outside of connection.c) is in purple_account_set_enabled().  The logic
> > there seems to be if wants_to_die is TRUE, as in the user as opted to
> log
> > out or something, then don't bother attempting to connect / disconnect.
> >
> > It seems that purple_connection_error_reason() and
> > purple_connection_error_is_fatal() are for setting gc->wants_to_die and
> not
> > accessing it.
>
> Well, purple_connection_error_is_fatal() is meant to replace checking if
> gc->wants_to_die is true.  wants_to_die is set to is_fatal() for
> backwards compatibility with code that checks wants_to_die.


purple_connection_error_is_fatal() expects a PurpleConnectionError reason.
So in, for example, purple_account_set_enabled(), what would that error be?
I'm not seeing how this function replaces the gc->wants_to_die check.

-Eoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20080131/c4a8233c/attachment.html>