pidgin: 7a36a9ec: patch from Andrew Gaul that fixes a meml...

Ka-Hing Cheung khc at hxbc.us
Thu Jul 3 12:46:19 EDT 2008


On Thu, 2008-07-03 at 11:27 -0500, Richard Laager wrote:
> The revision below reverts half (the other half was to yahoo_profile.c)
> of 7a490c356e10f7fff3432f875897aa0ca0ad1ff0, which Daniel committed from
> a Debian patch with this commit message:
> 
>         Fix a double-free in the yahoo profile/icon handling. This is from a downstream
>         Debian patch that has apparently been around forever, wasn't submitted to us.
>         Fixes #5889.
> 
> Should this code be there or not?

I think the patch from Andrew is correct. If purple_util_fetch_url
returns NULL then the callback is not called, so we need to do the frees
locally.

-khc





More information about the Devel mailing list