bot-sentry pidgin msn spam interaction

[deckrider]

On Fri, Jul 11, 2008 at 12:55:53PM -0600, deckrider wrote:
> On Fri, Jul 11, 2008 at 12:19 PM, deckrider <deckrider at gmail.com> wrote:
> > On Fri, Jul 11, 2008 at 8:35 AM, Stu Tomlinson <stu at nosnilmot.com> wrote:
> >> On Thu, 2008-07-10 at 17:28 -0600, deckrider wrote:
> >>> Therefore I'd like to ask if a change to the msn protocol plugin might
> >>> be considered in this regard so that it won't open a new conversation
> >>> to report an error from a message sent automatically by a plugin that
> >>> couldn't get through when there is not already a conversation open.
> >>> There is a patch available in the above referenced bug report for
> >>> this.
> >>
> >> I don't like this, because this is how it used to be, and people who
> >> liked to send message & close window immediately were not being informed
> >> of failure to send messages, so it needs to be more clever than just "no
> >> conversation already open".
> >
> > I agree, Stu:  certainly my patch is _not_ clever (mostly its a blunt
> > pointer to the issue).  Do you have any recommendations on the best
> > way of handling this via the pidgin API?
> >
> 
> Just had one thought occur to me, bot-sentry sends its automated
> messages this way:
> 
> prpl_info->send_im(pconn, recipient, message, PURPLE_MESSAGE_AUTO_RESP);
> 
> I wonder if it would be possible to know of the
> PURPLE_MESSAGE_AUTO_RESP flag and decide not to open a new
> conversation?  Haven't really looked at the pidgin code in this regard
> yet.

I had a look at this today, it appears to me that by the time there is
an error to report, the PurpleMessageFlags associated with the IM that
received the error are not available.

I wonder then if it would hurt to add PurpleMessageFlags to the
MsnMessage struct so that could be available later?