Pidgin freezes when XMPP server silently disappears

[Bron Gondwana]

On Sun, Jul 20, 2008 at 09:51:35PM -0400, Elliott Sales de Andrade wrote:
> On Sun, Jul 20, 2008 at 9:42 AM, Bron Gondwana <brong at fastmail.fm> wrote:
> > I'm currently fiddling with Djabberd, and restarting the server
> > quite frequently as I test out new code.
> >
> > Each time, Pidgin freezes for quite a few seconds (haven't
> > calculated exactly) - the interface just plain freezes, nothing
> > works, the buddy list doesn't redraw.
> >
> > It looks to me like something is failing to check for disconnection
> > and blindly leaving the POLLIN on an fd (14 and 15 in this case - I
> > have two different accounts on the same testing server) after
> > consuming (or failing to consume) an EOF notification on that socket.
> >
> 
> There was a recent commit made that should fix this:
> http://developer.pidgin.im/viewmtn/revision/info/1d533cebad7c0dbda8ec8ebee1334d27dcae5f9c
> 
> Changelog:
> Only check for EAGAIN if read returned less than 0. This fixes a bug
> where the recv callback function would get called continuously if the
> server closed our connection and errno happened to be set to EAGAIN.

Ahh.  Excellent.  Yes, I'm running 2.4.3 as packaged by Ubuntu Hardy -
sorry for not including that information.

Bron ( thankfully too busy at work to have raised a separate ticket
       in the pidgin bugtracking system today! )