[PATCH 1/4] Make request_user_display static.

Felipe Contreras felipe.contreras at gmail.com
Mon Jun 23 17:48:58 EDT 2008


On Tue, Jun 24, 2008 at 12:22 AM, Richard Laager <rlaager at wiktel.com> wrote:
> On Sun, 2008-06-22 at 18:03 +0300, Felipe Contreras wrote:
>> -void msn_request_user_display(MsnUser *user);
>> +static void request_user_display(MsnUser *user);
>
> This is a great example of the sort of thing that has been mentioned to
> you before. To make this static, you only need to add the keyword
> "static" to the prototype and the function definition itself. You did
> that and then renamed the function for no reason.

Reason: improves readability; there's no reason to prefix static functions.

-- 
Felipe Contreras




More information about the Devel mailing list