[PATCH 2/4] Use NULL instead of "offline" for the user status.

Ka-Hing Cheung khc at hxbc.us
Tue Jun 24 13:20:42 EDT 2008

On Tue, 2008-06-24 at 13:20 +0300, Felipe Contreras wrote:
> That's complete and utterly wrong, and I don't know how nobody else
> noticed after more than one year. Any time an error comes without
> payload, bang! And by the way, I don't think I've ever seen an error
> with a payload.

Masca have reported a crash to me couple months ago and we've found
this. I talked to Stu about it and he told me some errors can have
payloads, but ya, I've never seen one myself.

> By the way, the whole msn_check_payload_cmd introduced by mayuan goes
> against my design; the payload_len field should be set by the command
> handler, only after processing the command, so that all cases are
> handled.
> This generalization is completely wrong.

I agree.

More information about the Devel mailing list