GObject signals

[Gary Kramlich]

Sadrul Habib Chowdhury wrote:

<snip>

>> I wouldn't advise using the g_* namespace, unless you're planning on
>> pushing that as a patch up to glib.  and if so, add a glib version check
>> around it when it gets accepted.
>>
> 
> I renamespaced the function to purple_type_connect, and submitted a
> patch in GNOME bugzilla (#540256). (we can rename to g_* if/once the
> patch is accepted)
> 
> Sadrul
> 

Ok, but that means if it's accepted we then need a wrapper or a define
around it.  IE:

#if GLIB_CHECK_VERSION(2,18,0)
# define purple_signal_connect_type g_signal_connect_type
#endif

If you left it as g_signal_connect_type with a #if
!GLIB_CHECK_VERSION(2,18,0), it'd just work, and no code would need to
get touched later.  And if this method were to be used i'd drop it in a
glib-compat.h or something (we have one of those right...?)

-- 
Gary Kramlich <grim at reaperworld.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20080625/b18a559f/attachment.sig>