[PATCH] Fix bug in "manual" GNOME proxy handling
Jeff Connelly
shellreef at gmail.com
Tue Mar 4 23:22:09 EST 2008
2008/3/4 Michael Ellerman <michael at ellerman.id.au>:
> In libpurple/proxy.c, purple_gnome_proxy_get_info() uses gconftool to
> get the GNOME proxy settings. It explicitly looks for proxy type =
> "none", in which case no proxy is used, and also proxy type = "manual"
> in which case the global pidgin proxy is used.
>
> However the check for "manual" is missing a ! on the strcmp(), so it
> incorrectly falls through.
For what it is worth, I've used g_str_equal() instead of strcmp()
throughout the MySpaceIM protocol plugin to avoid this particular
mistake.
g_str_equal() was intended to be used with glib to compare strings
within hash tables, but it works pretty well as a general-purpose
function, and has saner return values.
-Jeff
More information about the Devel
mailing list