pidgin: d5ef30aa: These things are always NULL, so these i...

[Mark Doliner]

On Wed, 05 Mar 2008 08:59:35 -0500, Stu Tomlinson wrote
> On Wed, 2008-03-05 at 04:46 -0500, markdoliner at pidgin.im wrote:
> > -----------------------------------------------------------------
> > Revision: d5ef30aafa0c0ecff773017ab7ac542f9ba7b4b4
> > Ancestor: cce3a22f53972bd3834175b08ad5e7b800bf98e9
> > Author: markdoliner at pidgin.im
> > Date: 2008-03-05T09:40:16
> > Branch: im.pidgin.pidgin
> > URL:
http://d.pidgin.im/viewmtn/revision/info/d5ef30aafa0c0ecff773017ab7ac542f9ba7b4b4
> > 
> > Modified files:
> >         libpurple/proxy.c
> > 
> > ChangeLog: 
> > 
> > These things are always NULL, so these if statements are never triggered
> 
> They're always NULL on the first call to 
> purple_gnome_proxy_get_info(), but will not be NULL on subsequent 
> calls when using a proxy specified in GNOME. Methinks this 
> introduces quite a leak.

Oh yeah, because 'info' is a static variable.  You're right.  And when you're
right, you're right.  And you?  You're always right!  Should be fixed now.

-Mark