[PATCH] Fix bug in "manual" GNOME proxy handling

[Mark Doliner]

On Wed, 19 Mar 2008 09:55:45 -0700, Sean Egan wrote
> 2008/3/18 Michael Ellerman <michael at ellerman.id.au>:
> >  Did this hit the floor? I tried looking in ViewMTN but couldn't see how
> >  to search if a patch has been applied.
> 
> Yes, it did. Patches are much better sent to our tracker at
> http://d.pidgin.im, where we're better set up to handle them.
> 
> Anyway, the patch is certainly incorrect; if that setting is not set
> to manual, we don't understand it, and so stop looking at GNOME
> settings. I believe when the code was written, GNOME supported only
> "none" and "manual," and "manual" only supported HTTP.
> 
> It looks like now GNOME supports more: SOCKS and https, as well as
> "Automatic proxy configuration" and an exclusion list. All of these
> things would obviously be great to support, and I'd love to see you
> write a new patch for it! :)

I agree with all of this.  Sean said this way better than I ever could.

-Mark