soc.2008.finch: cc5d4c83: Converted window property of frame to a ...

[Mark Schneider]

On Tue, Sep 16, 2008 at 9:05 AM, Casey Harkins <caseyharkins at gmail.com> wrote:
>
> On Tue, 2008-09-16 at 02:15 -0400, queueram at soc.pidgin.im wrote:
>> -----------------------------------------------------------------
>> Revision: cc5d4c83e8930185cbb901492f76b43e65b6b7d5
>> Ancestor: 08ce9be835b88c64a691ba283582fa12495e15c2
>> Author: queueram at soc.pidgin.im
>> Date: 2008-09-16T06:11:16
>> Branch: im.pidgin.soc.2008.finch
>> URL: http://d.pidgin.im/viewmtn/revision/info/cc5d4c83e8930185cbb901492f76b43e65b6b7d5
>>
>> Modified files:
>>         finch/libgnt/wms/tiling.c
>>
>> ChangeLog:
>>
>> Converted window property of frame to a GQueue containing all the windows
>> that are contained within that frame.  This helps when a window's focus is
>> set by something outside of the tiling window manager (such as the taskbar)
>> and the frame it is contained within needs to be updated accordingly.
>>
>
>
> Is our glib requirement still 2.0 or is 2.4 the minimum? This commit
> uses a few g_queue functions that were added in 2.4. If it is still 2.0,
> g_queue_find() will need to be implemented internally and we'll need to
> look at the length member of the queue structure rather than use the
> g_queue_get_length() function.
>
> libpurple/protocols/oscar/flap_connection.c is also using
> g_queue_get_length(), though was not introduced in this commit.
>
>
> -casey
>

Ah, good catch.  I have to admit i wasn't paying any attention to the
glib version required for any of the functions i was calling.  If 2.0
is still the minimum, i can easily incorporate these changes.

Thanks for keeping an eye out.

-Mark