pidgin: ce52a4af: More tests, some with an international f...

Mark Doliner mark at kingant.net
Fri Jul 10 18:43:03 EDT 2009


On Fri, Jul 10, 2009 at 1:36 PM, Paul Aurich<paul at darkrain42.org> wrote:
> And markdoliner at pidgin.im spoke on 07/10/2009 11:55 AM, saying:
>> Revision: ce52a4af6787aad5221596cca9b17c86441bad96
>> Ancestor: 3b27bba79b515334a330931ff490d75e2d3787de
>> Author: markdoliner at pidgin.im
>
>> ChangeLog:
>>
>> More tests, some with an international flavor.  I have no idea what that
>> string means... I just copied it from an email
>> ============================================================
>> --- libpurple/tests/test_jabber_jutil.c       d4bb72464a3e1758fee94cf7663b129384f0ac82
>> +++ libpurple/tests/test_jabber_jutil.c       3c0ea5f94d7c42751e2be32201dda36b0498caad
> <snip>
>> @@ -100,6 +103,11 @@ START_TEST(test_jabber_id_new)
>>       assert_invalid_jid("/Test at 12345");
>>       assert_invalid_jid("mark.doliner@");
>>       assert_invalid_jid("mark.doliner/");
>> +     assert_valid_jid("mark.doliner at gmail_stuff.org");
>> +     assert_valid_jid("mark.doliner at gmail[stuff.org");
>> +     assert_valid_jid("mark.doliner at gmail/stuff.org");
>
> I keep reading this one and thinking "but '/' isn't valid in a domain name!" :)
>
>> +     assert_valid_jid("mark.doliner at gmail\\stuff.org");
>
> Is this valid in IDNA/DNS?

Oh deary me.  No.  Copy/paste error--those last three should have been
assert_invalid_jid.  Fixed now, thanks.

Of course, now the tests fail :-P  Investigating.

-Mark




More information about the Devel mailing list