Proposed changes for Pidgin 2.7.0
felipe.contreras at gmail.com
Tue Jul 14 22:35:57 EDT 2009
On Tue, Jul 14, 2009 at 10:26 PM, Ka-Hing Cheung<khc at hxbc.us> wrote:
> On Tue, 2009-07-14 at 12:17 +0300, Felipe Contreras wrote:
>> On Mon, Jul 13, 2009 at 9:15 PM, Casey Ho<pidgin at caseyho.com> wrote:
>> > With respect to plugins, most would benefit from this change. The Facebook
>> > prpl is full of glib version checks.
>> msn-pecan is also full of glib version checks.
>> I would vote for 2.14 due to g_timeout_add_seconds; which is specially
>> important if you want to use Pidgin in an embedded device due to power
>> usage, and I want to do that.
> There's no reason to require a new glib for this one, plugins should not
> use g_timeout_add_seconds() directly (or other glib mainloop calls), it
> should use purple_timeout_add_seconds()
g_timeout_add_seconds was introduced for a reason, not just to
unburden programmers from the hassle of thinking in milliseconds. So,
in order to properly use g_timeout_add_seconds, you of course need a
GLib version that supports that function, otherwise there's no
advantage of using purple_timeout_add_seconds over purple_timeout_add.
I'll take the word "should" in your comment as a "recommended", and
so, in msn-pecan we simply ignored that recommendation. I am not aware
of any drawbacks of using the GLib's mainloop, since it can be easily
hooked up into other mainloops (Adium is able to do that just fine).
If you know of any drawback, please let me know... but that's for
another thread (or personal email).
More information about the Devel