Proposed changes for Pidgin 2.7.0

Felipe Contreras felipe.contreras at gmail.com
Wed Jul 15 07:17:10 EDT 2009


On Wed, Jul 15, 2009 at 7:14 AM, John Bailey<rekkanoryo at rekkanoryo.org> wrote:
> Felipe Contreras wrote:
>> On Tue, Jul 14, 2009 at 7:11 PM, John Bailey<rekkanoryo at rekkanoryo.org> wrote:
>>> Libpurple, since 2.1.0, includes purple_timeout_add_seconds() which does the
>>> same thing.  We did this specifically so older glib installations could benefit
>>> as well.  This function also has the benefit of not requiring the glib mainloop
>>> like g_timeout_add_seconds() does.  For Pidgin and Finch users, this distinction
>>> is irrelevant, but other UI's may wish not to use glib's mainloop and instead
>>> have their own.  Some UI's may even be *forced* to use a non-glib mainloop.
>>
>> "g_timeout_add_seconds(1, ..." is obviously not the same as
>> "g_timeout_add(1 * 1000, ..."
>>
>> So, no, purple_timeout_add_seconds is not doing the same thing
>> compiled for GLib 2.12 than for GLib 2.14.
>
> Yes, I chose my words poorly there.  The point is that you don't have to care
> whether glib 2.14.x is in use, as I pointed out in another reply.  If you know
> you need power-saving timer groupings for a given embedded device and you know
> that your applications use glib, make sure you're using a new enough glib to
> make it work.

Resource optimization is something everybody wants, not just embedded
devices. If you are not willing to require a GLib version that would
make Pidgin perform optimally, at the very least you should add a
warning to say that at least 2.14 is *recommended*.

-- 
Felipe Contreras




More information about the Devel mailing list