Always call purple_privacy_check() for incoming IMs

Mark Doliner mark at kingant.net
Fri Jul 31 15:15:14 EDT 2009


On Fri, Jul 31, 2009 at 12:13 PM, Mark Doliner<mark at kingant.net> wrote:
> How do people feel about the attached diff?  It changes serv_got_im()
> to always call purple_privacy_check(), regardless of whether the PRPL
> has implemented a set_permit_deny callback function.
>
> It effectively does client-side blocking of incoming IMs regardless of
> the protocol.  This has no effect for AIM, where the server enforces
> the permit/deny setting.  But it benefits ICQ, where the permit/deny
> setting controls invisibility and our block list is actually a list of
> people to whom you're invisible.  Other protocols this might affect:
> MSN, Yahoo, Novell, Sametime.
>
> Based on Sulabh's email thread it seemed like people tended to be in
> favor of this.
>
> -Mark
>

(with the diff this time)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_privacy_for_all_protocols.diff
Type: text/x-diff
Size: 1033 bytes
Desc: not available
URL: <http://pidgin.im/pipermail/devel/attachments/20090731/bec8f67d/attachment-0002.diff>


More information about the Devel mailing list