pidgin: 80c06f69: Change yahoo_codes_to_html() to use the ...

[Mark Doliner]

On Fri, Jul 31, 2009 at 6:56 PM, Stu Tomlinson<stu at nosnilmot.com> wrote:
> On Fri, Jul 31, 2009 at 22:50, <markdoliner at pidgin.im> wrote:
>> -----------------------------------------------------------------
>> Revision: 80c06f6950b5ea3ca311d8e4752ad5b19ea84059
>> Ancestor: 20e16d28b924016a1310911f9b12376bba9a9859
>> Author: markdoliner at pidgin.im
>> Date: 2009-07-31T21:44:52
>> Branch: im.pidgin.pidgin
>> URL: http://d.pidgin.im/viewmtn/revision/info/80c06f6950b5ea3ca311d8e4752ad5b19ea84059
>>
>> Modified files:
>>        libpurple/protocols/yahoo/util.c
>>        libpurple/tests/test_yahoo_util.c
>>
>> ChangeLog:
>>
>> Change yahoo_codes_to_html() to use the same USE_CSS_FORMATTING #define
>> that myspace uses.  If this is defined then we send css formatting to
>> the core.  Otherwise we send the old font tags to the core.  This maintains
>> compatability will old UIs which might not support span tags.
>>
>> We should probably set this flag for both Pidgin and Finch
>
> Shouldn't this be a runtime thing instead of compile-time if we want
> the behaviour to vary depending on the UI in use?

That would probably be better, but I don't think it's too important.
I don't see a strong need for UIs to use CSS formatting right now,
since they currently have to support font tags anyway.

My hope is that we can get rid of this for 3.0.0 and always use CSS
formatting.  I see it more as a way for us to work on making CSS
formating work correctly in the current code without breaking
compatibility for existing UIs.  A little like
PURPLE_DISABLE_DEPRECATED.

-Mark