mark at kingant.net
Thu Jun 18 15:46:28 EDT 2009
On Thu, Mar 12, 2009 at 9:49 PM, Masca <salinasv at gmail.com> wrote:
> On Thu, Mar 12, 2009 at 8:47 PM, Mark Doliner <mark at kingant.net> wrote:
>> We have this handy flag that signals to the core that an incoming IM
>> or chat message is "delayed." Our sound playing code doesn't play a
>> sound if the flag is set. The Message Notification plugin doesn't
>> notify if the flag is set. And the Finch GntHistory plugin sets the
>> flag when prepending recent conversation history into an IM window.
>> The ONLY place this flag is set is when receiving a "delayed" Jabber
>> conference message. This has generally been used to send you the
>> recent room history when you join a conference room.
>> My question: Is there any reason we're not setting this flag all over
>> the place? Like when receiving an offline IM on all our protocols? I
>> feel like there was a reason we weren't doing this for IMs, but I
>> don't remember what it was. And it might be nice for UIs to know that
>> a message is delayed without having to look at the timestamp on the
> I think is a good idea to set the DELAYED flag to offline im. And want
> to point you to the patch at #2994,
I thought about this some more and I'm really on the fence. It might
not make sense to set the DELAYED flag because maybe not all protocols
are able to differentiate between a normal IM and an offline message?
And so it might make more sense for a UI to do this check on it's on.
"if timestamp > 1 minute ago then show in a different font color"
So I guess I'm not going to make this change.
More information about the Devel