Another hiding question

Mark Doliner mark at kingant.net
Mon Mar 16 18:51:19 EDT 2009


2009/3/15  <aluink at gmail.com>:
> In gtkblist.c:1181 the cnode->next should be changed to
> purple_blist_node_next(cnode, bool) where bool is TRUE, FALSE, or will it
> depend on some setting?
>
> In case your code lines are slightly different than mine,
>
> /* in gtk_blist_row_collapsed_cb */
>   for(cnode = purple_blist_node_get_first_child(node); cnode; cnode =
> cnode->next) {  /* This line here */
>     if (PURPLE_BLIST_NODE_IS_CONTACT(cnode)) {
>       gtknode = cnode->ui_data;
>       if (!gtknode->contact_expanded)
>         continue;
>       gtknode->contact_expanded = FALSE;
>       pidgin_blist_update_contact(NULL, cnode);
>     }       }

I think you should use TRUE.  That code collapses all contacts inside
a group when the group is collapsed.  And we should collapse offline
contacts regardless of whether they're being displayed.

-Mark




More information about the Devel mailing list