pidgin: e83f93ec: Add some safety to jabber_send_signal_cb...

[Elliott Sales de Andrade]

On Thu, Nov 26, 2009 at 1:30 PM, Paul Aurich <paul at darkrain42.org> wrote:

> On Nov 25, 2009, at 11:08, nosnilmot at pidgin.im wrote:
> > Modified files:
> >        libpurple/protocols/jabber/jabber.c
> >
> > ChangeLog:
> >
> > Add some safety to jabber_send_signal_cb in case someone else was
> listening
> > to jabber-sending-xmlnode and caused the connection to get disconnected
> > before the signal got to calling jabber_send_signal_cb. Should fix
> > https://bugzilla.redhat.com/show_bug.cgi?id=540835
>
>
> I'm not convinced this is how the crash is occurring.
>
> From the backtrace, frame 10 indicates this code path is being triggered by
> a FT request denial.  I'm guessing the FT request dialog isn't closed when
> an account disconnects (I don't have Pidgin handy, so I can't confirm that,
> but the request dialog uses the xfer as the purple_request_ handle, not gc).
>

While I can't say it's the cause of this crash in particular, I can say I
have noticed this behaviour. Whether it's because of NM disconnecting or
just the account itself, file transfer requests tend to stick around in the
FT dialog until you do something about them (whether it's for sending or
receiving).


> It seems like a better (and more general) solution would be to close all
> xfers when an account disconnects, otherwise crashes like this probably
> exist in other prpls (unless they also use PURPLE_CONNECTION_IS_VALID).
>
> ~Paul
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20091126/1a89f075/attachment-0001.html>