2.6.2: check test build fail on powerpc-apple-darwin8

[David Fang]

Hi again,

> 	I'm seeing the following error during make check for pidgin 2.6.2 
> (new since 2.6.1).
>
> /bin/sh ../../libtool --silent --tag=CC --mode=link gcc  -g -Os  -L/sw/lib -o 
> check_libpurple  check_libpurple-check_libpurple.o 
> check_libpurple-test_cipher.o check_libpurple-test_jabber_jutil.o 
> check_libpurple-test_qq.o check_libpurple-test_yahoo_util.o 
> check_libpurple-test_util.o -L/sw/lib -lcheck -L/sw/lib -lgobject-2.0 
> -lgmodule-2.0 -lgthread-2.0 -lglib-2.0 -lintl 
> ../../libpurple/protocols/jabber/libjabber.la 
> ../../libpurple/protocols/qq/libqq.la 
> ../../libpurple/protocols/yahoo/libymsg.la ../../libpurple/libpurple.la -ldb 
> -lpthread -lresolv  -Wl,-framework,IOKit -Wl,-framework,CoreFoundation
>
> *** Warning: Linking the executable check_libpurple against the loadable 
> module
> *** libqq.so is not portable!
> *** Warning: lib libqq.so is a module, not a shared library
>
> *** And there doesn't seem to be a static archive available
> *** The link will probably fail, sorry
> /usr/libexec/gcc/powerpc-apple-darwin8/4.0.1/ld: 
> ../../libpurple/protocols/qq/.libs/libqq.so is input for the dynamic link 
> editor, is not relocatable by the static link editor again
> collect2: ld returned 1 exit status
> make[4]: *** [check_libpurple] Error 1

I've 'fixed' this locally by creating a non-module libqq.la:

(libpurple/protocols/qq/Makefile.am):
noinst_LTLIBRARIES += libqq_test.la
libqq_test_la_SOURCES = $(QQSOURCES)
libqq_test_la_LIBADD = $(libqq_la_LIBADD)

(libpurple/tests/Makefile.am):
check_libpurple_LDADD=\
 	...
                 $(top_builddir)/libpurple/protocols/qq/libqq_test.la \
 	...


and now this links correctly, and passes tests.

make  check-TESTS
Running suite(s): Master Suite
  Cipher Suite
  Jabber Utility Functions
  QQ
  Yahoo Utility Functions
  Utility Functions
100%: Checks: 80, Failures: 0, Errors: 0
PASS: check_libpurple
==================
All 1 tests passed
==================

I'm not sure if this is how you'd want to fix it, but hopefully this is 
enough information for a proper fix.  If needed, I can create the above 
patch.

Thanks for developing pidgin and finch!

Fang


David Fang
http://www.csl.cornell.edu/~fang/
http://www.achronix.com/