PurpleCipher breakout

[Elliott Sales de Andrade]

On Mon, Feb 14, 2011 at 3:51 PM, Gary Kramlich <grim at reaperworld.com> wrote:
> On 02/14/2011 01:09 PM, Mark Doliner wrote:
>>
>> On Sun, Feb 13, 2011 at 10:59 PM, Gary Kramlich<grim at reaperworld.com>
>>  wrote:
>>
>>>
>>> I just pushed a new branch to break the hash/cipher implementations out
>>> to separate files.  The branch is named im.pidgin.cipher_breakout.
>>>
>>
>> What's the motivation for moving it into a separate directly and
>> building it as a convenience library?
>>
>
> Adding ciphers isn't a fun task to begin with, even less so when you have to
> jump around a 3000+ line file.  The convenience library was built to get the
> source files out of the main purple source directory.  There's enough going
> on there that we don't need to add 8 new source files to it.

Sure, but do we need the convenience library (and thus the extra API,
if I understand the reasoning)? I'm pretty sure we have stuff in
libpurple/media/ that doesn't require a convenience library to get it
included.

>
> --
> Gary Kramlich <grim at reaperworld.com>
>

-- 
Elliott aka QuLogic
Pidgin developer