API enhancement for 2.8.0

Andrew Victor avictor.za at gmail.com
Tue May 3 17:37:18 EDT 2011


I've committed a version of this patch to im.pidgin.pidgin.next.major for now.
 * move 'tooltip' field to end of struct.
 * remove the "if (tooltip != NULL)" checks since they're not necessary.
 * wrap GTK tooltip calls in "#if GTK_CHECK_VERSION(2,12,0)" checks.

 Andrew Victor

On Mon, Apr 11, 2011 at 9:00 PM, Andrew Victor <avictor.za at gmail.com> wrote:
> hi,
>> Moving 'tooltip' to the end of the struct would *probably* be acceptable
>> (since only request.c should be malloc()ing the struct.
> Ok, I can move the "tooltip" to the end of the struct.
>> This should be investigated (and possibly tested), since tooltip-text=""
>> might show a blank tooltip, which would be horrid.
> I have tested it now:
>  * tooltip-text="" does not show anything.
>  * tooltip-text=NULL does not show anything either.
> So unless purple_request_field_set_tooltip() is called, it will work
> as it does now and no tooltip is displayed.
> Can I commit this patch via the MXit branch for 2.8.0?

More information about the Devel mailing list