/pidgin/main: f19649cf724b: Actually remove purple_conversation_...

Richard Laager rlaager at wiktel.com
Sun Dec 30 14:08:28 EST 2012

On Sun, 2012-12-30 at 12:50 -0500, John Bailey wrote:
> On Sun, Dec 30, 2012 at 2:34 AM, Mark Doliner <mark at kingant.net> wrote:
> > Actually remove purple_conversation_do_command
> >
> > We don't call this function ourselves.  Was it intended for plugins or
> > something...?  I already added an entry for this to ChangeLog.API,
> > so if we revert this comment we should revert that commit, too.
> It is used by the irchelper plugin and a couple others.  I'm not sure
> we should be blindly removing this.

I only looked at this for literally a total of about 1 minute, but it
seems they are using purple_cmd_do_command(). And I saw in the commit
that purple_conversation_do_command() said it was similar to
purple_cmd_do_command(). Perhaps we don't really need both?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20121230/78a08010/attachment.sig>

More information about the Devel mailing list