/pidgin/main: 2733eca1dc96: Fix a warning and (null) in file tra...

Mark Doliner mark at kingant.net
Mon Oct 22 02:29:23 EDT 2012

On Sun, Oct 21, 2012 at 1:42 PM, Tomasz Wasilczyk
<tomkiewicz at cpw.pidgin.im> wrote:
> Author:  Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>
> Description:
> Fix a warning and (null) in file transfer window
> -                       return g_strdup_printf("%" G_GSIZE_FORMAT " %s", size, size_str[size_index]);
> +                       return g_strdup_printf("%" G_GOFFSET_FORMAT " %s", size, _(size_str[size_index]));

I noticed that we use G_GOFFSET_FORMAT in a few different places.
Unfortunately it was added in glib 2.20 and our configure.ac in master
allows glib as far back to 2.16.0.

We need to do one of the following:
- Stop using G_OFFSET_FORMAT
- Conditionally #define G_OFFSET_FORMAT in libpurple/internal.h
- Bump up the the minimum allowed version of glib in configure.ac

More information about the Devel mailing list