/pidgin/main: 71533f0d5dc0: win32: switch to OBS, update and pus...

[Daniel Atallah]

On Mon, Apr 8, 2013 at 8:15 PM, Tomasz Wasilczyk <tomkiewi at gmail.com> wrote:
> 2013/4/8 Daniel Atallah <datallah at pidgin.im>:
>> On Sun, Apr 7, 2013 at 4:22 PM, Tomasz Wasilczyk
>> <tomkiewicz at cpw.pidgin.im> wrote:
>>> Changeset: 71533f0d5dc06a5a5ecfc7dee1713a83e184534b
>>> Author:  Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>
>>> Date:    2013-04-07 22:22 +0200
>>> Branch:  default
>>> URL: https://hg.pidgin.im/pidgin/main/rev/71533f0d5dc0
>>>
>>> Description:
>>>
>>> win32: switch to OBS, update and push to runtime-deps package - libenchant, gtkspell, meanwhile, tcl
>>
>> <SNIP>
>>
>>> diff --git a/pidgin/win32/nsis/generate_gtk_zip.sh b/pidgin/win32/nsis/generate_gtk_zip.sh
>>> @@ -103,10 +104,13 @@ LIBSTDCPP="${DOWNLOAD_HOST}mingw32-libst
>>>  LIBTIFF="${DOWNLOAD_HOST}mingw32-libtiff-4.0.2-1.4.noarch.rpm libtiff 4.0.2-1.4 sha1sum:9a8f8b018e8bafd47067fe6fd0debc1e887239b1"
>>>  LIBXML="${DOWNLOAD_HOST}mingw32-libxml2-2.8.0-2.6.noarch.rpm libxml 2.8.0-2.6 sha1sum:9be07823d7074362abac17bf7a7b092659aed002"
>>>  LIBXSLT="${DOWNLOAD_HOST}mingw32-libxslt-1.1.27-1.4.noarch.rpm libxslt 1.1.27-1.4 sha1sum:4a08612ad73235b0fab95e17644d72e8f24097c3"
>>> +MEANW="${DOWNLOAD_HOST}mingw32-meanwhile-1.0.2-2.6.noarch.rpm Meanwhile 1.0.2-2.6 sha1sum:afce5c0157c270ee30c049fdabd7328fa3b3233e"
>>
>> It occurred to me this morning that you switched out libmeanwhile to
>> the OBS version - the version we've shipping has 5 patches for various
>> issues (upstream isn't maintained, so we've had to patch it
>> ourselves).  The patches are in the zip file linked to off of the
>> BuildingWinPidgin wiki page.  Assuming these patches aren't already in
>> the OBS version, we either need to get the patches integrated in the
>> OBS version or revert back to the old binary.
>
> My bad, that I didn't mentioned it in the commit (but I was aware of it).
>
> I'll contact Fridrich about ensuring that OBS ships fixed version. If
> I fail with this, I could try the other way: just compiling it from
> source with patches before bundling. Just like we should treat such
> cases, when there is no real possibility to get it updated at
> upstream.

Ok, thanks.  I wouldn't expect these patches to be controversial.

-D