/pidgin/main: b6f09494adda: cross-win32: hide glib bug of mismat...

LRN lrn1986 at gmail.com
Thu Apr 17 10:14:02 EDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17.04.2014 18:05, Daniel Atallah wrote:
> I don't think this is going to work correctly - we need to use g_stat 
> because it handles mapping the filename to the appropriate encoding
> before calling the native API - internal strings in libpurple are UTF-8
> and are converted to w_char before calling _wstat().
> 
> If you look at 
> https://developer.gnome.org/glib/2.30/glib-File-Utilities.html#g-stat 
> there's an explanation of what's going on.
> 
> GStatBuf needs to be the 32-bit stat structure (since it's going to call 
> _wstat()) - this default behavior for mingw, but not for mingw64 or MSVC.
> 
> gstdio.h has some special handling for msvc, but not (yet?) for mingw64
> (I guess an upstream patch is probably appropriate to fix that).
> 
> If mingw64 is being used for 32-bit builds, we'll need to redefine stat
> to _stat32 before gstdio.h is included or redefine GStatBuf to _stat32
> after the include.

Or just use GFileInfo.

- -- 
O< ascii ribbon - stop html email! - www.asciiribbon.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)

iQEcBAEBAgAGBQJTT+GlAAoJEOs4Jb6SI2CwfDAIAMl2Ce5O9Nb4fpw5v69ar7il
Teolwn3qJ0Rr51F0Sqr0BL2u7XCqVhs37nkYLjOuuRAwPVtCi5rs0Mgl2Tp2I34Q
CUFg7dNVZ1+19Fi9TsrJ0ubm6Z6LCuBhLthfrmNaHAaGlkr4JIJ6C6wN6qxa7NCk
6nYlyOMnC9aXbOG8ZEs+w2WJ4oQ1OxzcwweLKh480mm5GIpPHVGzp2KdkqO8ZmgD
PUJZJtZdlCaiG+4RCw6WYkYG3qX8vQgAo3grdI6n7myjSB+JkK5/XeqVqBSgjA+/
aPgTsMjUe5oKU8X1xwNDOu6H5d5CD6yYD5WyijCie7VGBoE4dm87D+BB8P41kZw=
=n0ox
-----END PGP SIGNATURE-----



More information about the Devel mailing list