/pidgin/main: 48e4e99bb831: Fix win32 build

[Daniel Atallah]

On Sat, Jan 4, 2014 at 8:12 PM, Tomasz Wasilczyk <twasilczyk at pidgin.im>wrote:

> Changeset: 48e4e99bb831c00d172e57b9ee958d759d8bc142
> Author:  Tomasz Wasilczyk <twasilczyk at pidgin.im>
> Date:    2014-01-05 02:12 +0100
> Branch:  default
> URL: https://hg.pidgin.im/pidgin/main/rev/48e4e99bb831
>
> Description:
>
> Fix win32 build
>
> diffstat:
>
>  pidgin/Makefile.mingw |  3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diffs (24 lines):
>
> diff --git a/pidgin/Makefile.mingw b/pidgin/Makefile.mingw
> --- a/pidgin/Makefile.mingw
> +++ b/pidgin/Makefile.mingw
> @@ -44,10 +44,12 @@ INCLUDE_PATHS +=    \
>                         -I$(GTK_TOP)/lib/gtk-2.0/include \
>                         -I$(GTKSPELL_TOP)/include/gtkspell-2.0 \
>                         -I$(LIBSOUP_TOP)/include/libsoup-2.4 \
> +                       -I$(LIBGADU_TOP)/include \
>                         -I$(WEBKITGTK_TOP)/include/webkitgtk-1.0
>
>  LIB_PATHS +=           -L$(GTK_TOP)/lib \
>                         -L$(WEBKITGTK_TOP)/lib \
> +                       -L$(LIBGADU_TOP)/lib \
>                         -L$(PURPLE_TOP) \
>                         -L$(PIDGIN_TOP) \
>                         $(VV_LIB_PATHS)
> @@ -135,6 +137,7 @@ PIDGIN_LIBS =       \
>                 -lgdk-win32-2.0 \
>                 -lgdk_pixbuf-2.0 \
>                 -lgdi32 \
> +               -lgadu \
>                 -lwinmm \
>                 $(VV_LIBS) \
>                 -lwebkitgtk-1.0
>


This doesn't seem right - pidgin itself shouldn't depend on libgadu.

If you look at the other things that are comparable  (other plugin
dependencies) none of those have a version displayed (presumably for the
same reason).

It occurred to me that displaying the version like this is also potentially
wrong - theoretically the gg plugin (or all of libpurple) could be updated
independently of pidgin.

Perhaps there should be a way to have plugins print some sort of debugging
information that could be displayed on this window?
Having all of this information based more on runtime state would be
preferable in a lot of ways.

-D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pidgin.im/pipermail/devel/attachments/20140105/d259a553/attachment.html>