/pidgin/main: 3a6156743d75: Fix a warning about missing expand p...

[Gary Kramlich]

I backed this out because I can't produce this warning (to figure out the
right fix) and it horribly breaks my conversation window.  See
https://bitbucket.org/pidgin/main/commits/3a6156743d752b150ac473edff6e5b481db951b3


On Mon, Mar 17, 2014 at 4:20 AM, Tomasz Wasilczyk <twasilczyk at pidgin.im>wrote:

> Changeset: 3a6156743d752b150ac473edff6e5b481db951b3
> Author:  Tomasz Wasilczyk <twasilczyk at pidgin.im>
> Date:    2014-03-17 10:19 +0100
> Branch:  default
> URL: https://hg.pidgin.im/pidgin/main/rev/3a6156743d75
>
> Description:
>
> Fix a warning about missing expand property
>
> diffstat:
>
>  pidgin/gtkwebview.c |  40 ++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 40 insertions(+), 0 deletions(-)
>
> diffs (57 lines):
>
> diff --git a/pidgin/gtkwebview.c b/pidgin/gtkwebview.c
> --- a/pidgin/gtkwebview.c
> +++ b/pidgin/gtkwebview.c
> @@ -1494,6 +1494,37 @@ pidgin_webview_finalize(GObject *webview
>         G_OBJECT_CLASS(parent_class)->finalize(G_OBJECT(webview));
>  }
>
> +enum {
> +       PROP_0,
> +       PROP_EXPAND
> +};
> +
> +static void
> +pidgin_webview_set_property(GObject *object, guint prop_id, const GValue
> *value,
> +       GParamSpec *pspec)
> +{
> +       g_return_if_fail(PIDGIN_IS_WEBVIEW(object));
> +
> +       switch (prop_id) {
> +               case PROP_EXPAND:
> +                       purple_debug_misc("webview",
> +                               "Ignored expand property (set to %d)",
> +                               g_value_get_boolean(value));
> +                       break;
> +               default:
> +                       G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id,
> +                               pspec);
> +       }
> +}
> +
> +static void
> +pidgin_webview_get_property(GObject *object, guint prop_id, GValue
> *value, GParamSpec *pspec)
> +{
> +       g_return_if_fail(PIDGIN_IS_WEBVIEW(object));
> +
> +       G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
> +}
> +
>  static void
>  pidgin_webview_class_init(PidginWebViewClass *klass, gpointer userdata)
>  {
> @@ -1579,6 +1610,15 @@ pidgin_webview_class_init(PidginWebViewC
>         gtk_binding_entry_add_signal(binding_set, GDK_KEY_r,
> GDK_CONTROL_MASK,
>                                      "format-cleared", 0);
>
> +       /* properties */
> +
> +       G_OBJECT_CLASS(klass)->set_property = pidgin_webview_set_property;
> +       G_OBJECT_CLASS(klass)->get_property = pidgin_webview_get_property;
> +       g_object_class_install_property(G_OBJECT_CLASS(klass),
> +               PROP_EXPAND, g_param_spec_boolean("expand",
> +                       "not used", "It's just a fix, don't use it.",
> FALSE,
> +                       G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
> +
>         purple_prefs_add_none(PIDGIN_PREFS_ROOT "/webview");
>         purple_prefs_add_bool(PIDGIN_PREFS_ROOT
> "/webview/inspector_enabled", FALSE);
>  }
>
> _______________________________________________
> Commits mailing list
> Commits at pidgin.im
> https://pidgin.im/cgi-bin/mailman/listinfo/commits
>



-- 
Thanks,

--
Gary Kramlich <grim at reaperworld.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pidgin.im/pipermail/devel/attachments/20140322/0b57d4f1/attachment.html>