GSoC is over

[Jorge Villaseñor]

On Mon, Oct 19, 2015 at 10:07 PM, Jorge Villaseñor <salinasv at gmail.com>
wrote:

>
> On Mon, Oct 19, 2015 at 1:00 PM, Koosha Khajehmoogahi <
> koosha.khajeh at gmail.com> wrote:
>
>> I *think* I did it but the head apparently has changed. Sorry, I don't
>> have professional experience with Mercurial; I'm a git guy. Please let
>> me know if there is anything that needs to be changed/reverted.
>>
>>
> Hi Koosha, maybe you didn't pushed to your repository after the merge.
> I tried to pull your changes, merge the main default branch with your
> changes but it doesn't merge cleanly.
>
> Can you try again so we can review it easily? If you can't we can try it
> ourself but it makes more sense for you to merge the changes since you know
> better what is going on in there
>
>
Hi all. I reviewed the code for XMPP improvements and I am not 100% sure it
is ready to be merged.

The main concerns are that XEP-280 does a change in sever.c (rev
9c71168e8a68) that I think could break other prpls. We need to verify that
and/or fix other prpls.
On this regard, jgeboski and dx mentioned that our message API may need a
modification to completely support this usecase which is also used by
facebook's plugin. So it may worth revisit the Libpurple side of this
change.

Also, there are a couple of TODOs
which may break the history  (rev 9681c39416ec) or
looks like the feature is not complete (rev 9681c39416ec).

I merged main/default to GSoC branch and did a nice diff to make it easier
to see only the changes introduced on this branch (find attached the diff).

I would like you guys to review and suggest if we should cherry-pick some
of the complete features / code improvements

repository history: https://hg.pidgin.im/soc/2015/koosha/main/graph

-- 
Masca

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pidgin.im/pipermail/devel/attachments/20151108/5433b5e0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmpp.patch
Type: text/x-diff
Size: 45804 bytes
Desc: not available
URL: <https://pidgin.im/pipermail/devel/attachments/20151108/5433b5e0/attachment-0001.patch>