Merge PR?
Gary Kramlich
grim at reaperworld.com
Wed Apr 25 13:58:56 EDT 2018
On Wed, Apr 25, 2018 at 11:36 AM, Joakim Tjernlund <
Joakim.Tjernlund at infinera.com> wrote:
> On Fri, 2018-04-20 at 08:26 +0100, David Woodhouse wrote:
> > On Wed, 2018-04-18 at 14:16 +0000, Joakim Tjernlund wrote:
> > > There are a few PR which has been approved but not merged, what is
> > > holding merge back? Who merges?
> > > I would love to see the latest PRs by David W. to merged and released
> > > ASAP.
> >
> > I'm not sure if people are expecting me to merge the approved PRs
> > myself (and if they need two approvals).
> >
> > Once upon a time I was able to do that, but if I do still have
> > sufficient privs then I'm not aware of it.
>
> I think the silence speaks ...
> There are no rules, just best effort/adhoc, so I think you should try
> merging yourself if possible.
The silence speaks of us being busy. Remember this is a volunteer project
and no one gets paid to work on it, which means it's a free time project.
Some times we have more free time than normal. That said, causing us to
reply to "omg why haven't you done this one simple thing" means that we now
have to reply to you as well, which cuts into that tiny portion of
freetime. If you'd like to actually help the project, please by all means,
review the pull requests and be constructive, but this gung-ho make it
happen stuff doesn't help the project.
That said, I should have some time tonight after the Instant Messaging
Freedom board meeting to look at these. Yes I've already approved them, I
was hoping to get some more eyes on them and hopeful we will before I get
to them, but we'll see.
Jocke
>
Thanks,
--
Gary Kramlich <grim at reaperworld.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pidgin.im/pipermail/devel/attachments/20180425/6e6d33a5/attachment.html>
More information about the Devel
mailing list