<div dir="ltr">I backed this out because I can't produce this warning (to figure out the right fix) and it horribly breaks my conversation window.  See <a href="https://bitbucket.org/pidgin/main/commits/3a6156743d752b150ac473edff6e5b481db951b3">https://bitbucket.org/pidgin/main/commits/3a6156743d752b150ac473edff6e5b481db951b3</a></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 17, 2014 at 4:20 AM, Tomasz Wasilczyk <span dir="ltr"><<a href="mailto:twasilczyk@pidgin.im" target="_blank">twasilczyk@pidgin.im</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Changeset: 3a6156743d752b150ac473edff6e5b481db951b3<br>
Author:  Tomasz Wasilczyk <<a href="mailto:twasilczyk@pidgin.im">twasilczyk@pidgin.im</a>><br>
Date:    2014-03-17 10:19 +0100<br>
Branch:  default<br>
URL: <a href="https://hg.pidgin.im/pidgin/main/rev/3a6156743d75" target="_blank">https://hg.pidgin.im/pidgin/main/rev/3a6156743d75</a><br>
<br>
Description:<br>
<br>
Fix a warning about missing expand property<br>
<br>
diffstat:<br>
<br>
 pidgin/gtkwebview.c |  40 ++++++++++++++++++++++++++++++++++++++++<br>
 1 files changed, 40 insertions(+), 0 deletions(-)<br>
<br>
diffs (57 lines):<br>
<br>
diff --git a/pidgin/gtkwebview.c b/pidgin/gtkwebview.c<br>
--- a/pidgin/gtkwebview.c<br>
+++ b/pidgin/gtkwebview.c<br>
@@ -1494,6 +1494,37 @@ pidgin_webview_finalize(GObject *webview<br>
        G_OBJECT_CLASS(parent_class)->finalize(G_OBJECT(webview));<br>
 }<br>
<br>
+enum {<br>
+       PROP_0,<br>
+       PROP_EXPAND<br>
+};<br>
+<br>
+static void<br>
+pidgin_webview_set_property(GObject *object, guint prop_id, const GValue *value,<br>
+       GParamSpec *pspec)<br>
+{<br>
+       g_return_if_fail(PIDGIN_IS_WEBVIEW(object));<br>
+<br>
+       switch (prop_id) {<br>
+               case PROP_EXPAND:<br>
+                       purple_debug_misc("webview",<br>
+                               "Ignored expand property (set to %d)",<br>
+                               g_value_get_boolean(value));<br>
+                       break;<br>
+               default:<br>
+                       G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id,<br>
+                               pspec);<br>
+       }<br>
+}<br>
+<br>
+static void<br>
+pidgin_webview_get_property(GObject *object, guint prop_id, GValue *value, GParamSpec *pspec)<br>
+{<br>
+       g_return_if_fail(PIDGIN_IS_WEBVIEW(object));<br>
+<br>
+       G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);<br>
+}<br>
+<br>
 static void<br>
 pidgin_webview_class_init(PidginWebViewClass *klass, gpointer userdata)<br>
 {<br>
@@ -1579,6 +1610,15 @@ pidgin_webview_class_init(PidginWebViewC<br>
        gtk_binding_entry_add_signal(binding_set, GDK_KEY_r, GDK_CONTROL_MASK,<br>
                                     "format-cleared", 0);<br>
<br>
+       /* properties */<br>
+<br>
+       G_OBJECT_CLASS(klass)->set_property = pidgin_webview_set_property;<br>
+       G_OBJECT_CLASS(klass)->get_property = pidgin_webview_get_property;<br>
+       g_object_class_install_property(G_OBJECT_CLASS(klass),<br>
+               PROP_EXPAND, g_param_spec_boolean("expand",<br>
+                       "not used", "It's just a fix, don't use it.", FALSE,<br>
+                       G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));<br>
+<br>
        purple_prefs_add_none(PIDGIN_PREFS_ROOT "/webview");<br>
        purple_prefs_add_bool(PIDGIN_PREFS_ROOT "/webview/inspector_enabled", FALSE);<br>
 }<br>
<br>
_______________________________________________<br>
Commits mailing list<br>
<a href="mailto:Commits@pidgin.im">Commits@pidgin.im</a><br>
<a href="https://pidgin.im/cgi-bin/mailman/listinfo/commits" target="_blank">https://pidgin.im/cgi-bin/mailman/listinfo/commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Thanks,<div><br></div><div>--</div><div>Gary Kramlich <<a href="mailto:grim@reaperworld.com" target="_blank">grim@reaperworld.com</a>></div>
</div>
</div>