Wrong buffer size calcualtion in msn_httpconn_parse_data

Mark Doliner mark at kingant.net
Mon Aug 8 00:20:33 EDT 2011

On Thu, Jul 14, 2011 at 8:37 AM, Marius Wachtler <undingen at gmail.com> wrote:
> My compiler found a bug

What compiler are you using??  It seems to be good at finding bugs.

>        buf = s;
>        size -= (s - buf);
> The last two lines should be swaped, otherwise the buffer size will
> not be reduced.

Yep, I totally agree.  As currently written the "size -= (s - buf)"
line is always a no-op.


More information about the security mailing list