[Pidgin] #78: Fix Bi-Directional text issues in gtkimhtml and MSN protocol

[Pidgin]

#78: Fix Bi-Directional text issues in gtkimhtml and MSN protocol
---------------------------+------------------------------------------------
  Reporter:  shlomil       |       Owner:  rlaager                                     
      Type:  patch         |      Status:  new                                         
  Priority:  major         |   Milestone:                                              
 Component:  pidgin (gtk)  |     Version:  2.0                                         
Resolution:                |    Keywords:  Hebrew bidi RTL Arabic "bi-directional text"
---------------------------+------------------------------------------------
Comment (by shlomil):

 Changes in the second version of the patch:

  * Eliminated code duplication - gtk_imhtml_is_amp_escape(),
 gtk_imhtml_get_css_opt() functions were removed. libpurple introduces 2
 new functions:
   * purple_markup_detect_entity() - was a private function in libpurple
 now renamed and made public. It does exactly the same thing as
 gtk_imhtml_is_amp_escape(),
   * purple_markup_get_css_property() - replaces gtk_imhtml_get_css_opt().
 Function was buggy and therefore rewritten from scratch.
  * changed variable naming style (isrtlmessage => is_rtl_message , etc)
  * removed usage of the "0 == ..." idiom.
  * Hardcoded line gtkconv.c : isrtlmessage = (purple_strcasestr(message,
 "<SPAN style=\"direction:rtl;") != NULL); - was changed to parse CSS
 correctly.
  * fixed some code styling issues: removed the braces for single lines,
 spaces in function arguments.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/78#comment:4>
Pidgin <http://pidgin.im>
Pidgin