[Pidgin] #196: reduce code duplication when producing account and protocol option menus
Pidgin
trac at pidgin.im
Wed Apr 18 02:41:27 EDT 2007
#196: reduce code duplication when producing account and protocol option menus
-----------------------------+----------------------------------------------
Reporter: nix_nix | Type: patch
Status: new | Priority: minor
Component: pidgin (gtk) | Version: 2.0
Keywords: codeduplication |
-----------------------------+----------------------------------------------
I am following a suggestion that I submit my patch via trac, rather than
the ml:
In the spirit of code duplication reduction, please find attached a patch
that uses a common set of functions to produce both account and protocol
option menus.
It doesn't save /that/ much (just over 40 lines), but it doesn't (seem to)
break anything, and it introduces some useful functions like
GdkPixbuf *get_prpl_pixbuf (PurpleProtocolPluginInfo *info) ;
This function is used in the creation of both types of option menus.
--
Ticket URL: <http://developer.pidgin.im/ticket/196>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list