[Pidgin] #192: document prpl_info->list_icon(NULL, NULL)

Pidgin trac at pidgin.im
Wed Apr 18 21:43:32 EDT 2007


#192: document prpl_info->list_icon(NULL, NULL)
------------------------+---------------------------------------------------
  Reporter:  jeff       |       Owner:                         
      Type:  patch      |      Status:  reopened               
  Priority:  minor      |   Milestone:                         
 Component:  libpurple  |     Version:  2.0                    
Resolution:             |    Keywords:  msimprpl msim myspaceim
------------------------+---------------------------------------------------
Comment (by rlaager):

 The patch is fine except for the fact that you used spaces instead of tabs
 there. Please change that to use tabs and then feel free to commit it. In
 your commit message, write "Closes #192" and this ticket will be
 automatically closed.

 Remember that you want to commit this change to trunk, not to your SoC
 branch. If you're uneasy about this, feel free to ask someone in #pidgin
 for help or let me know and I can commit it. I'd just rather you do it so
 you get the experience. :)

 Also, if this is your first commit to trunk, add your name to COPYRIGHT.

 Finally, did you update your prpl to replace g_return_val_if_fail() with
 something proper?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/192#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list