[Pidgin] #398: Crash when updating a buddy's icon on MSN

[Pidgin]

#398: Crash when updating a buddy's icon on MSN
--------------------------+-------------------------------------------------
 Reporter:  nosnilmot     |       Owner:  rlaager
     Type:  defect        |      Status:  new    
 Priority:  blocker       |   Milestone:  2.0.0  
Component:  pidgin (gtk)  |     Version:  2.0    
 Keywords:                |  
--------------------------+-------------------------------------------------
 I had commented out the clearing of buddy icons in slp.c:958 earlier, now
 I uncommented it and I crashed when a buddy changed their icon on MSN.
 {{{
 (gdb) bt
 #0  0x0013d402 in __kernel_vsyscall ()
 #1  0x005baf90 in raise () from /lib/libc.so.6
 #2  0x005bc678 in abort () from /lib/libc.so.6
 #3  0x080b2eac in sighandler (sig=11) at gtkmain.c:212
 #4  <signal handler called>
 #5  0x00196c9f in purple_imgstore_get_filename (img=0x95959595) at
 imgstore.c:105
 #6  0x0017fccf in purple_buddy_icon_update (icon=0x8aa04f0) at
 buddyicon.c:399
 #7  0x0017fe91 in purple_buddy_icon_set_data (icon=0x8aa04f0, data=0x0,
 len=0, checksum=0x0) at buddyicon.c:455
 #8  0x001800e4 in purple_buddy_icons_set_for_user (account=0x8279318,
 username=0x8a92ad0 "mybuddy at hotmail.com", icon_data=0x0, icon_len=0,
 checksum=0x0) at buddyicon.c:522
 #9  0x06d6eca9 in msn_queue_buddy_icon_request (user=0x8a9a2f8) at
 slp.c:958
 #10 0x06d75846 in msn_user_set_object (user=0x8a9a2f8, obj=0x0) at
 user.c:315
 #11 0x06d69359 in nln_cmd (cmdproc=0x88cf480, cmd=0x8a9a3f0) at
 notification.c:692
 #12 0x06d5d03b in msn_cmdproc_process_cmd (cmdproc=0x88cf480,
 cmd=0x8a9a3f0) at cmdproc.c:313
 #13 0x06d5d0f0 in msn_cmdproc_process_cmd_text (cmdproc=0x88cf480,
 command=0x8c8e058 "NLN NLN mybuddy at hotmail.com Buddy 1073741856 0") at
 cmdproc.c:335
 #14 0x06d6c98e in read_cb (data=0x88cfec8, source=27,
 cond=PURPLE_INPUT_READ) at servconn.c:445
 #15 0x0809cdb7 in pidgin_io_invoke (source=0x892dc20, condition=G_IO_IN,
 data=0x8958ee8) at gtkeventloop.c:77
 #16 0x0585f2ac in g_vasprintf () from /usr/lib/libglib-2.0.so.0
 #17 0x058383b0 in g_main_context_dispatch () from
 /usr/lib/libglib-2.0.so.0
 #18 0x0583b3a6 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
 #19 0x0583b6c8 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
 #20 0x04fbccb5 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
 #21 0x080b3bf7 in main (argc=1, argv=0xbfdd74a4) at gtkmain.c:837
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/398>
Pidgin <http://pidgin.im>
Pidgin