[Pidgin] #2520: msimprpl crashes if set signed-on signal handler
Pidgin
trac at pidgin.im
Sun Aug 12 14:54:05 EDT 2007
#2520: msimprpl crashes if set signed-on signal handler
------------------------+---------------------------------------------------
Reporter: jeff | Owner: jeff
Type: defect | Status: closed
Priority: major | Milestone:
Component: libpurple | Version: 2.1.0
Resolution: fixed | Keywords: msimprpl
Pending: 0 |
------------------------+---------------------------------------------------
Comment (by jeff2 at soc.pidgin.im):
(In [53a2863ad47fd4f4e5a044af320bc59b0ee6056c]) Only say we are connected
after the MsimSession structure is fully setup.
(Also change a few debugging statements to help find this bug.)
Previously, purple_connection_set_state(..., PURPLE_CONNECTED) was called
too early, so that if a client called any msimprpl functions that operated
on MsimSession (pretty much all of them) within the signed-on signal
handler,
the userid etc., would not yet be correct and the call would fail. Now,
the
call is called at the right time so it works as expected.
Closes #2520.
--
Ticket URL: </ticket/2520#comment:4>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list