[Pidgin] #2571: libpurple is not reflecting nick changes back to the server list

[Pidgin]

#2571: libpurple is not reflecting nick changes back to the server list
------------------------+---------------------------------------------------
  Reporter:  zphd44     |       Owner:                          
      Type:  defect     |      Status:  new                     
  Priority:  minor      |   Milestone:                          
 Component:  libpurple  |     Version:  2.1.0                   
Resolution:             |    Keywords:  msn nick synchronization
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by QuLogic):

 Oh, I found that quite annoying...

 From what I can tell, libpurple has a `store_name` (the nickname on the
 server) and a `friendly_name` (the nickname the client displays) for every
 user. I guess that was so that libpurple could refer to the stored name
 when talking to the server. With the REA command, that seems a little bit
 redundant.

 I've written a patch that removes `store_name` and changes the nickname on
 the server whenever `friendly_name` has changed. (I think removing the
 `store_name` API is OK, since it's internal to the MSN prpl.) I've tested
 it with name changes, and it seems to work fine.

 For whoever might be applying this, you don't need to wait for MSNP14,
 since REA is replaced with a different command there, anyway. I'd say this
 is still useful for removing the duplicate storage of nicknames. There are
 some superfluous changes from `store_name` to `friendly_name` just so that
 I wouldn't find them with a search/grep. I can remove those to simplify
 the patch, if you want.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2571#comment:1>
Pidgin <http://pidgin.im>
Pidgin