[Pidgin] #2720: msimprpl disconnects or crashes when adding non-existent buddy

[Pidgin]

#2720: msimprpl disconnects or crashes when adding non-existent buddy
------------------------+---------------------------------------------------
  Reporter:  jeff       |       Owner:  jeff    
      Type:  defect     |      Status:  assigned
  Priority:  minor      |   Milestone:          
 Component:  libpurple  |     Version:  2.1.1   
Resolution:             |    Keywords:  msimprpl
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by jeff):

 If the buddy can't be looked up, msimprpl sends:

 \addbuddy\\sesskey\144425370\newprofileid\0\reason\\final\

 This value is substituted in by the postprocessing.

 {{{
 (21:34:17) msim: msim_postprocess_outgoing: msg before=<MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 reason(string):
 /MsimMessage>
 (21:34:17) msim: >>> msim_postprocess_outgoing: couldn't find username
 tom239483948 in blist
 (21:34:17) msim: msim_postprocess_outgoing - scheduling lookup,
 msg=<MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: msim_lookup_userid: asynchronously looking up
 <tom239483948>
 (21:34:17) msim: msim_lookup_user: data=<MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: msim_send_raw: writing
 <\persist\1\sesskey\140157912\cmd\1\dsn\5\uid\180301984\lid\7\rid\4\body\UserName=tom239483948\final\>
 (21:34:17) msim: msim_msg_send()ing <MsimMessage:
 persist(integer): 1
 sesskey(integer): 140157912
 cmd(integer): 1
 dsn(integer): 5
 uid(integer): 180301984
 lid(integer): 7
 rid(integer): 4
 body(dict): <MsimMessage:
 UserName(string): tom239483948
 /MsimMessage>
 /MsimMessage>
 (21:34:17) msim: buffer at 0 (max 15360), reading up to 15360
 (21:34:17) msim: msim_input_cb: going to null terminate at n=84
 (21:34:17) msim: msim_input_cb: read=84
 (21:34:17) msim: msim_parse: got
 <\persistr\\cmd\257\dsn\5\uid\180301984\lid\7\rid\4\body\UserName=tom239483948>
 (21:34:17) msim: msim_process_reply: calling callback now
 (21:34:17) msim: for msg=<MsimMessage:
 persistr(raw):
 cmd(raw): 257
 dsn(raw): 5
 uid(raw): 180301984
 lid(raw): 7
 rid(raw): 4
 body(raw): UserName=tom239483948
 /MsimMessage>
 (21:34:17) msim: msim_postprocess_outgoing_cb() got msg=<MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: msim_do_postprocessing msg: <MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: msim_postprocess_outgoing_cb: postprocessed
 msg=<MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 newprofileid(integer): 0
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: msim_send_raw: writing
 <\addbuddy\\sesskey\140157912\newprofileid\0\reason\\final\>
 (21:34:17) msim: msim_msg_send()ing <MsimMessage:
 addbuddy(boolean): TRUE
 sesskey(integer): 140157912
 newprofileid(integer): 0
 reason(string):
 _username(string): tom239483948
 _uid_field_name(string): newprofileid
 _uid_before(string): reason
 /MsimMessage>
 (21:34:17) msim: buffer at 0 (max 15360), reading up to 15360
 (21:34:17) msim: msim_input_cb: going to null terminate at n=72
 (21:34:17) msim: msim_input_cb: read=72
 (21:34:17) msim: msim_parse: got <\error\\err\1\fatal\\errmsg\There was an
 error parsing a request.>
 (21:34:17) msim: msim_error (sesskey=140157912): Protocol error, code 1:
 There was an error parsing a request.
 (21:34:17) msim: fatal error, closing
 (21:34:17) msim: buffer at 0 (max 15360), reading up to 15360
 (21:34:17) msim: msim_input_cb: server disconnected
 (21:34:17) account: Disconnecting account 0x8461c0
 (21:34:17) connection: Disconnecting connection 0xf60ef0
 (21:34:17) connection: Destroying connection 0xf60ef0
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2720#comment:2>
Pidgin <http://pidgin.im>
Pidgin