[Pidgin] #2752: libpurple lets you add buddies to blist inside groups that aren't on blist; leads to duplicate groups

Pidgin trac at pidgin.im
Fri Aug 24 02:24:02 EDT 2007


#2752: libpurple lets you add buddies to blist inside groups that aren't on blist;
leads to duplicate groups
------------------------+---------------------------------------------------
  Reporter:  jeff       |       Owner:  jeff    
      Type:  defect     |      Status:  closed  
  Priority:  trivial    |   Milestone:          
 Component:  libpurple  |     Version:  2.1.1   
Resolution:  fixed      |    Keywords:  msimprpl
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by jeff2 at soc.pidgin.im):

 (In [fea00266488c85ba94e735d5885d991298e8f9d7]) Add an assertion in
 purple_blist_add_{chat,buddy} to return if a buddy was
 added to the buddy list in a group that is not in the buddy list. This
 improper usage previously caused duplicate groups to be shown in the
 buddy list, which are then dropped after restarting Pidgin.

 This change may incur a performance hit on every buddy added to the buddy
 list with a non-null group. If this performance is noticeably worse, an
 alternate assertion (which is less readable) can be used as #2752.

 Closes #2752.

-- 
Ticket URL: </ticket/2752#comment:9>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list