[Pidgin] #2810: Non-XHTML-IM messages with links in them are broken.

Mon Aug 27 14:42:57 EDT 2007

#2810: Non-XHTML-IM messages with links in them are broken.
-----------------------+----------------------------------------------------
 Reporter:  deryni     |       Owner:       
     Type:  defect     |      Status:  new  
 Priority:  blocker    |   Milestone:  2.2.0
Component:  libpurple  |     Version:  2.1.1
 Keywords:             |     Pending:  0    
-----------------------+----------------------------------------------------
 I'm not sure who changed the linkification code to separate out the link
 target and the link text (I think it was for text-only logging) but I
 think something about that change broke non-XHTML-IM XMPP messages.

 14:04:56 <deryni> If you type something like ejabberd at router into the
 window the plaintext message sends with <body>ejabberd at router
 <mailto:ejabberd at router></body>

 14:05:25 <deryni> Which is decidedly busted.

 14:05:57 <seanega1> yeah

 14:06:00 <seanega1> that might be my fault.

 14:06:56 <seanega1> But I think all I really did was say "if the bit in
 the ctext is the same as the bit in the href, don't add the ctext at all

 14:07:07 <seanega1> so it might have been the fault of whoever did it
 before me.

 14:07:26 <deryni> Yeah, I thought you were supposed to fix the duplication
 in the logs for that.

 14:07:28 <seanega1> And, I was only testing against Gmail chat, so that's
 probably why it seemed to work

 14:07:34 <deryni> I think the original change is what broke it.

 14:07:44 <seanega1> I think so too

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2810>
Pidgin <http://pidgin.im>
Pidgin