[Pidgin] #2824: Port retry on fail and Save working port

Pidgin trac at pidgin.im
Tue Aug 28 17:15:39 EDT 2007


#2824: Port retry on fail and Save working port
------------------------+---------------------------------------------------
  Reporter:  Jaywalker  |       Owner:  shellreef
      Type:  patch      |      Status:  new      
  Priority:  minor      |   Milestone:  2.2.0    
 Component:  libpurple  |     Version:  2.1.1    
Resolution:             |    Keywords:  msimprpl 
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by Jaywalker):

 Replying to [comment:7 khc]:
 > it seems better to reverse the 2 ifs, so one of the duplicate check can
 be eliminated.

 I looked at that already and I ran into the problem of... if i is 8 (the
 last port) and the last port is the port we started with, it will
 increment that... Then the new incremented value becomes 9 which is out of
 range and must be caught. The "duplicate check" is only so we don't check
 if (altports[9] == deadport) and get an out of range exception. That's the
 only way my mind could think to do it... sketchy as it may be :-/

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2824#comment:8>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list