[Pidgin] #4315: Fix NTLM endian-ness.

Pidgin trac at pidgin.im
Fri Dec 7 23:50:25 EST 2007


#4315: Fix NTLM endian-ness.
--------------------------+-------------------------------------------------
 Reporter:  QuLogic       |       Type:  patch
   Status:  new           |   Priority:  minor
Component:  libpurple     |    Version:  2.3.1
 Keywords:  ntlm, endian  |    Pending:  0    
--------------------------+-------------------------------------------------
 So, I found a TODO in ntlm.c that said "Will this work on both little-
 endian and big-endian machines?". To fix this, I used the
 [http://www.innovation.ch/java/ntlm.html link to documentation] that was
 at the top of the file.

 Essentially, all the multi-byte values were required to be little-endian.
 I've added some `GUINT{16/32}_TO_LE` calls around all the relevant values.

 Of course, I don't actually use NTLM or have a big-endian machine, so
 someone else will need to test this.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4315>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list