[Pidgin] #4345: Pidgin crashing when attempting to enable SIP account

[Pidgin]

#4345: Pidgin crashing when attempting to enable SIP account
----------------------+-----------------------------------------------------
  Reporter:  nix_nix  |       Owner:  seanegan
      Type:  defect   |      Status:  new     
  Priority:  minor    |   Milestone:          
 Component:  SIMPLE   |     Version:  2.3.1   
Resolution:           |    Keywords:          
   Pending:  0        |  
----------------------+-----------------------------------------------------
Comment (by nix_nix):

 {{{
 Breakpoint 1, sipmsg_parse_header (
     header=0x8168000
 "UNKNOWNsip:nix_nix_nix at 88.113.2.57:5060;transport=tcp SIP/2.0\r\nRecord-
 Route: <sip:198.65.166.131;ftag=394741787;lr>\r\nVia: SIP/2.0/UDP
 198.65.166.131;branch=z9hG4bKce9c.e43d69e6.2\r\nVia: SIP/2.0/UDP 198"...)
 at sipmsg.c:63
 63              if(!lines[0]) return NULL;
 (gdb) print lines[0]
 $12 = (gchar *) 0x83a0810
 "UNKNOWNsip:nix_nix_nix at 88.113.2.57:5060;transport=tcp SIP/2.0"
 (gdb) cont

 Breakpoint 3, sipmsg_parse_header (
     header=0x8168000
 "UNKNOWNsip:nix_nix_nix at 88.113.2.57:5060;transport=tcp SIP/2.0\r\nRecord-
 Route: <sip:198.65.166.131;ftag=394741787;lr>\r\nVia: SIP/2.0/UDP
 198.65.166.131;branch=z9hG4bKce9c.e43d69e6.2\r\nVia: SIP/2.0/UDP 198"...)
 at sipmsg.c:69
 69                      return NULL;
 }}}

 {{{
 20:45 <_|Nix|_> This is interesting: $12 = (gchar *) 0x83a0810
 "UNKNOWNsip:nix_nix_nix at 88.113.2.57:5060;transport=tcp SIP/2.0"
 20:46 <_|Nix|_> Because now it goes to 69
 20:46 <elb> ok, great, that's the actual bug
 20:46 <_|Nix|_> It's poised to return NULL.
 20:46 <_|Nix|_> So, a malformed response?
 20:46 <elb> hmmm, it doesn't like that line, does it
 20:46 <elb> either a malformed response, or a response we don't recognize
 ...
 20:48 <elb> process_input needs an if (msg == NULL) { disconnect and post
 an error }
 20:48 <_|Nix|_> OK. What do you need me to do?
 20:48 <elb> well, there are two possibilities
 20:49 <elb> if you want to learn about SIP, make sure that's actually a
 bug, and implement the disconnect
 20:49 <elb> if not, file a bug :-)
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4345#comment:2>
Pidgin <http://pidgin.im>
Pidgin