[Pidgin] #1458: Single click on system tray icon should launch contact list
Pidgin
trac at pidgin.im
Thu Dec 13 13:46:45 EST 2007
#1458: Single click on system tray icon should launch contact list
------------------------------+---------------------------------------------
Reporter: Swifty | Owner: datallah
Type: enhancement | Status: assigned
Priority: minor | Milestone:
Component: winpidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
------------------------------+---------------------------------------------
Comment (by phroggie):
For reference from [http://msdn2.microsoft.com/en-us/library/ms645606.aspx
msdn docs], the order of events we'd receive for a double click are:
WM_LBUTTONDOWN, WM_LBUTTONUP, WM_LBUTTONDBLCLK, WM_LBUTTONUP.
Replying to [comment:3 datallah]:
> I'm inclined to make the single-click do what the double-click does now
(if there are pending messages, display them, otherwise show/hide the
Buddy List) and to make the double-click always show/hide the Buddy List.
I agree with this, but can only think of two feasible ways to achieve
this, given the order of events listed earlier, and limited time googling:
Option 1) Have the single-click callback wait !GetDoubleClickTime()
milliseconds before doing it's thing. In testing, even with an ultra quick
double click speed on a fast machine, this seems really slow.
Option 2) Immediately process the first WM_LBUTTONUP, then undo it's
effects when we receive a WM_LBUTTONDBLCLK and ignore the next
WM_LBUTTONUP. I see this as rather sub-optimal, and would absolutely
despise the dancing windows.
I strongly dislike both options, and think that the best way to use single
clicks in the docklet is in the attached patch (single click and double
click are treated the same).
--
Ticket URL: <http://developer.pidgin.im/ticket/1458#comment:8>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list