[Pidgin] #4382: Update to MSNP15

Pidgin trac at pidgin.im
Sat Dec 15 04:07:19 EST 2007


#4382: Update to MSNP15
----------------------+-----------------------------------------------------
  Reporter:  QuLogic  |       Owner:  khc                            
      Type:  patch    |      Status:  new                            
  Priority:  minor    |   Milestone:                                 
 Component:  MSN      |     Version:  2.3.1                          
Resolution:           |    Keywords:  MSNP15, ticket tokens, RPS, SSO
   Pending:  0        |  
----------------------+-----------------------------------------------------
Comment (by QuLogic):

 Ah, I think I've found the problem (two actually).

 First, the add and rename operations used `g_markup_printf_escaped` and
 that caused the ampersand in the ticket token to be escaped twice. I
 patched those two functions to escape only the group name and not the
 whole XML message (instead of changing the rest of the functions to escape
 things at the risk of introducing many bugs).

 Second, when moving a contact to a newly created group,
 `msn_group_read_cb` finds the GUID, prints it and adds it to the internal
 list, but then frees it before calling `msn_add_contact_to_group`. So the
 contact doesn't get moved at all.

 I've attached a fourth patch that should fix these issues. You'll probably
 need to apply the third patch first.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4382#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list