[Pidgin] #4322: [XMPP] Invisible mode violating standard

Pidgin trac at pidgin.im
Wed Dec 19 06:36:34 EST 2007


#4322: [XMPP] Invisible mode violating standard
---------------------+------------------------------------------------------
  Reporter:  js      |       Owner:  nwalp
      Type:  defect  |      Status:  new  
  Priority:  minor   |   Milestone:       
 Component:  XMPP    |     Version:  2.3.1
Resolution:          |    Keywords:       
   Pending:  1       |  
---------------------+------------------------------------------------------
Changes (by js):

  * pending:  1 => 0

Comment:

 In pidgin-2.3.1/libpurple/protocols/jabber/buddy.c:
 static void jabber_buddy_set_invisibility(JabberStream *js, const char
 *who, gboolean invisible)
 [[BR]]
 There is:
 {{{
         if(invisible) {
                 xmlnode_set_attrib(presence, "type", "invisible");
                 jb->invisible |= JABBER_INVIS_BUDDY;
         } else {
                 jb->invisible &= ~JABBER_INVIS_BUDDY;
         }
 }}}
 That looks to me like it sends a presence of type invisible. Instead,
 privacy lists should be used here.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4322#comment:8>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list