[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Sat Jun 2 02:28:25 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by rlaager):
Replying to [comment:34 o_sukhodolsky]:
> Replying to [comment:25 rlaager]:
>
> > I believe I've gotten everything but the [f]read/[f]write() changes
committed.
>
> you have missed the changes in proxy.c (it is to avoid "dereferencing
type-punned pointer")
>
> and there are two small fixes I've posted as a separate attachments (I
promise I will not add new fixes o this ticket any more :)
I've committed your changes to proxy.c in changeset
bdd3cb040100fe925456b862d03cc6c5a61648ef. I forgot to reference this
ticket, and I found out from the last commit (where I forgot to reference
this ticket) that a bug in Monotone makes it difficult to just change a
commit message.
Anyway, at this point we should again be down to just the [f]read/[f]write
changes. Could you generate a new patch against MTN with just those
changes? That'd be a lot easier for me to review. Thanks for your work
here!
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:37>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list